Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-exec] Fix anonymous records #585

Merged
merged 11 commits into from
Sep 25, 2024

Conversation

rbanerjee20
Copy link
Contributor

@rbanerjee20 rbanerjee20 commented Sep 20, 2024

Previously, anonymous records only properly worked in CN runtime testing when they were the return type of some CN predicate or function. Now anonymous records should work across the board at runtime, getting translated to C structs as before.

TODO: Revert CN tutorial examples to use records instead of datatypes and check that it works now.
TODO: Write small examples of anonymous records that are not the return types of CN predicates/functions and check that they work. Include in CI.

@rbanerjee20 rbanerjee20 marked this pull request as ready for review September 24, 2024 23:35
Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits/questions, but looks reasonable overall

backend/cn/lib/cn_internal_to_ail.ml Show resolved Hide resolved
backend/cn/lib/cn_internal_to_ail.ml Outdated Show resolved Hide resolved
backend/cn/lib/cn_internal_to_ail.ml Outdated Show resolved Hide resolved
backend/cn/lib/executable_spec_records.ml Show resolved Hide resolved
backend/cn/lib/cn_internal_to_ail.ml Show resolved Hide resolved
@rbanerjee20 rbanerjee20 merged commit 98434f0 into rems-project:master Sep 25, 2024
2 checks passed
@rbanerjee20 rbanerjee20 deleted the fix-anonymous-records branch September 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants