-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CN-exec] Fix anonymous records #585
Merged
rbanerjee20
merged 11 commits into
rems-project:master
from
rbanerjee20:fix-anonymous-records
Sep 25, 2024
Merged
[CN-exec] Fix anonymous records #585
rbanerjee20
merged 11 commits into
rems-project:master
from
rbanerjee20:fix-anonymous-records
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbanerjee20
force-pushed
the
fix-anonymous-records
branch
from
September 24, 2024 00:08
4303e8e
to
0ed6aee
Compare
…bing for pre+postconditions
rbanerjee20
force-pushed
the
fix-anonymous-records
branch
from
September 24, 2024 23:00
35cb68f
to
7b855e1
Compare
dc-mak
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits/questions, but looks reasonable overall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, anonymous records only properly worked in CN runtime testing when they were the return type of some CN predicate or function. Now anonymous records should work across the board at runtime, getting translated to C structs as before.
TODO: Revert CN tutorial examples to use records instead of datatypes and check that it works now.TODO: Write small examples of anonymous records that are not the return types of CN predicates/functions and check that they work. Include in CI.